Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Light3D Indirect Energy property in SDFGI #52252

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 30, 2021

The Indirect Energy property was previously ignored in SDFGI (unlike VoxelGI). I tested this change with directional, omni and spot lights and it works as expected.

This closes #39878.

Preview

  • The SpotLight3D on the left has Energy set to 1 and Indirect Energy set to 10.
  • The SpotLight3D on the right has Energy set to 4 and Indirect Energy set to 0.2.

image

@Calinou Calinou requested review from a team as code owners August 30, 2021 12:51
@Calinou Calinou added this to the 4.0 milestone Aug 30, 2021
The Indirect Energy property was previously ignored in SDFGI
(unlike VoxelGI).
@reduz reduz merged commit 3c554f0 into godotengine:master Sep 9, 2021
@Calinou Calinou deleted the sdfgi-use-light-indirect-energy branch September 9, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan: SDFGI ignores lights' Indirect Light scale property
2 participants